Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: De-dup arrays and string in VariableTable #946

Merged
merged 2 commits into from
Apr 3, 2018
Merged

Debugger: De-dup arrays and string in VariableTable #946

merged 2 commits into from
Apr 3, 2018

Conversation

chingor13
Copy link
Contributor

This is an optimization to reduce the payload size and time spent by the debugger.

stackdriver_debugger 0.2.0 adds an id field for captured variables (arrays, strings, objects). Implemented here.

If provided, use that id to de-dup variables in the VariableTable (previously we used spl_object_hash which is only available for objects).

This is useful for large arrays (like $_SERVER) so that we don't need to have multiple copies of the same nested data structure when reporting variables to stackdriver.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2018
@chingor13 chingor13 requested a review from tmatsuo March 23, 2018 18:10
@dwsupplee dwsupplee merged commit 1f10fab into googleapis:master Apr 3, 2018
@dwsupplee dwsupplee mentioned this pull request Apr 3, 2018
@chingor13 chingor13 deleted the debugger-array-dedup branch April 25, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants